gBroutin / gstreamer-java

Automatically exported from code.google.com/p/gstreamer-java
0 stars 0 forks source link

Event probe does not indicate whether to forward or drop events. #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Current signature of event probe (Pad.EVENT_PROBE) is:

    public static interface EVENT_PROBE {
        public void eventReceived(Pad pad, Event event);
    }

Having boolean as the return type would enable us to choose whether to
forward or drop events at the pad. At the moment, they seem to be dropped
silently. Returning a boolean value would help match the "have-data" signal
signature of:

gboolean user_function (GstPad *, GstMiniObject *mini_obj, gpointer data);

Reference:
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstPad.h
tml#GstPad-have-data

Original issue reported on code.google.com by balachan...@gmail.com on 10 May 2009 at 10:11

GoogleCodeExporter commented 8 years ago
Shouldn't be 

public static interface HAVE_DATA {
    public void haveData(Pad pad, MiniObject data);
}

the signal interface with the callback function returning a boolean value, 
instead of
EVENT_PROBE?

Right now I'm working in the 1.2 release, so I could include this improvement.

Original comment by andres.c...@gmail.com on 25 May 2009 at 2:02

GoogleCodeExporter commented 8 years ago
andres,

yes, returning a boolean value which determines whether the data is forwarded or
dropped is important. so that would be:

public static interface HAVE_DATA {
    public *boolean* haveData(Pad pad, MiniObject data);
}

right?

Original comment by balachan...@gmail.com on 26 Jul 2009 at 10:46

GoogleCodeExporter commented 8 years ago
we'll look into it...

Original comment by lfar...@gmail.com on 5 Nov 2009 at 6:03

GoogleCodeExporter commented 8 years ago
will be included in next release.

Original comment by d853211@gmail.com on 12 Nov 2009 at 3:46

GoogleCodeExporter commented 8 years ago

Original comment by lfar...@gmail.com on 15 Dec 2009 at 1:58

GoogleCodeExporter commented 8 years ago
thanks!

Original comment by balachan...@gmail.com on 15 Dec 2009 at 3:21