search

gBroutin / gstreamer-java

Automatically exported from code.google.com/p/gstreamer-java
0 stars 0 forks source link

Patch for PlayBin.getStreamInfo crash #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

PlayBin.getStreamInfo() crashes the JVM in gstreamer-java 1.4. I've fixed the 
problem - see attached patch. Could someone review and commit it to the SVN 
repository?

Thanks!

Cheers,

- Dave L

Original issue reported on code.google.com by naskies@gmail.com on 28 Jul 2010 at 5:49

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi, this has been an issue for me as well, it would be great if this was 
patched in.

Original comment by suih...@gmail.com on 28 Jul 2010 at 5:50

GoogleCodeExporter commented 8 years ago 
tshalif could you review this patch at least the final GValueArray part.
thanks

Original comment by lfar...@gmail.com on 24 Sep 2010 at 11:23

GoogleCodeExporter commented 8 years ago 
Patch review in progress..

Original comment by tsha...@gmail.com on 26 Sep 2010 at 8:41

GoogleCodeExporter commented 8 years ago 
In the original patch there is a change to the return type of 
g_value_get_object() in GValueAPI, which may break existing code - the newly 
added GValueTest fails.

I put a work-around for this problem under 
gstreamer-java.googlecode.com/svn/branches/gstreamer-java-stream-info. Also, in 
order for StreamInfo.getCaps() to work, I modified GObject.get() to enable type 
conversion of 'boxed' value properties for which a type is registered in 
GstTypes. I would like to investigate a bit more what are the reference 
counting implications of such a call to g_value_dup_boxed() before merging into 
trunk. Comments and code reviews of my suggested modifications are welcome.

Original comment by tsha...@gmail.com on 29 Sep 2010 at 11:07

GoogleCodeExporter commented 8 years ago 
I've checked the reference counting of 'boxed' GstCaps via GDB, seems to be OK. 
StreamInfo is a GObject, so I was able to to use the 'Tracker' in 
StreamInfoTest to test reference counting.

The patch is now merged into SVN trunk

Original comment by tsha...@gmail.com on 17 Oct 2010 at 1:05