Closed gMagicScott closed 9 years ago
just got done with gigs for the weekend. Give me a day or so to think about these details. Thank you!
The issue is that it depends on if they are using an "old" form or "new" form. The old forms work off of "Name" but the new forms work off of "mc-firstname" and "mc-lastname". So I'm not clear on what the solution could be besides having two versions of the firstname merge code, one for old and one for new.
And depending on the initial form, that will determine the hyperlink that populates. So I'm still not clear how we can address that because it depends if they're using the old form or new form on the initial step that leads them to the e-promo-kit. That will determine which version of the merge codes we need, which will then determine which version needs to show in the populated hyperlink.
No need to rush @twinsmagic to these. I'm just trying to brain dump any problems/ideas into one place for when we're ready to begin on 0.6.0. Feel free to start your own. I got a few labels set up. "On Deck" is anything that is truly ready to be worked on. Anything without a "status: X" is just mostly so it's not forgotten.
I find it easiest to think about each "page load" by itself.
When the page content contains this:
[as what="Name" default="(client full name)"]
[as what="firstname" default="(client first name)"]
[as what="lastname" default="(client last name)"]
An old form is submitted using Name
. We will call the client "John Doe"
Name
is available to merge. mc-firstname
and mc-lastname
are not available.
[as what="Name"]
mc-firstname
with mc-lastname
Since neither are available, continueName
if available This works. Use this value and stop here.mc-firstname
only We are already done, unneeded step.[as what="firstname"]
mc-firstname
It's not available, continue.Name
at first space and use first part This works, use this and stop here.[as what="lastname"]
mc-lastname
It's not available, continue.Name
at first space and use second part This works, use this and stop here.Output:
John Doe
John
Doe
An old form is submitted using Name
. We will call the client "John" (He didn't fill out his full name)
Name
is available to merge. mc-firstname
and mc-lastname
are not available.
[as what="Name"]
mc-firstname
with mc-lastname
Since neither are available, continueName
if available This works. Use this value and stop here.mc-firstname
only We are already done, unneeded step.[as what="firstname"]
mc-firstname
It's not available, continue.Name
at first space and use first part This works, use this and stop here.[as what="lastname"]
mc-lastname
It's not available, continue.Name
at first space and use second part Name is available, but there isn't a second part to use.Output:
John
John
(client last name)
A new form is submitted using mc-firstname
and mc-lastname
. We will call the client "John Doe"
Name
is not available to merge. mc-firstname
and mc-lastname
are available.
[as what="Name"]
mc-firstname
with mc-lastname
We got what we need, stop here.Name
if available We are already done, unneeded step.mc-firstname
only We are already done, unneeded step.[as what="firstname"]
mc-firstname
We got what we need, stop here.Name
at first space and use first part We are already done, unneeded step.[as what="lastname"]
mc-lastname
We got what we need, stop here.Name
at first space and use second part We are already done, unneeded step.Output:
John Doe
John
Doe
A new form is submitted using mc-firstname
and mc-lastname
. We will call the client "John" (He didn't fill out his full name)
Name
and mc-lastname
are not available to merge. mc-firstname
is available.
[as what="Name"]
mc-firstname
with mc-lastname
We don't have both parts, continue.Name
if available This isn't available, continue.mc-firstname
only We got what we need, stop here.[as what="firstname"]
mc-firstname
We got what we need, stop here.Name
at first space and use first part We are already done, unneeded step.[as what="lastname"]
mc-lastname
Field is not available, continue.Name
at first space and use second part Field is not available to split, continue.Output:
John
John
(client last name)
You can re-run any of those scenarios as a link that is either
example.com/e-promo-kit/?Name=$%name$%
Scenario 1 & 2example.com/e-promo-kit/?mc-firstname=$%firstname$%&mc-lastname=%$lastname$%
Scenario 3 & 4I think both of these are true, but they probably should be verified:
mc-firstname
and mc-lastname
fields submit and save correctly in 1Shop?Name
correctly merge first name and last name individually into an email? %$firstname$%
and %$lastname$%
As far as generating the link for use in emails, I don't think it matters, if both of those questions are true. For a link example.com/my-page/?key=value
, 1Shop won't care about key only that it can merge value. We just use consistent naming of the key for our own sanity.
just realized the populated link is using the wrong merge code for email. It's listed in the link as %$Email1$% but it's actually supposed to be %$email$%
been swamped with shows and travel man. Sorry for the delay. Thinking about this stuff now.
your 4 scenarios look and sound great man. Did you need any additional feedback?
Will an old style form with mc-firstname and mc-lastname fields submit and save correctly in 1Shop?
No, I don't believe so.
Will an old style form with Name correctly merge first name and last name individually into an email? %$firstname$% and %$lastname$%
yes, indeed.
when do you think I could get an updated zip file?
In a recent update, 1ShoppingCart split up how it handles client names. It used to only have a
Name
field (that still works) that contained the contact's full name. Now they have split it up:mc-firstname
containing only the first namemc-lastname
containing only the last nameDisplaying merge data on the front-end
Currently, there is are two "magic" fields:
[as what="firstname"]
[as what="lastname"]
They look at
Name
and split it at the first space into first and last names.I think the best solution is to use the first available
mc-firstname
ormc-lastname
Name
(the current way)For displaying the full name:
mc-firstname
+(space)
+mc-lastname
(as defined using above flow)mc-firstname
(as defined using above flow)Editor Button
In the available fields, according to the defaults, First Name and Name are available. They output
[as what="firstname"]
and[as what="Name"]
respectively. Of course that might change depending on what settings are provided on the admin page.I think Name is still good as-is. Should we
mc-firstname
?mc-lastname
?Autoresponder merge link
When generating the link, currently the variations of first and last name are combined to only use Name:
firstname
mc-firstname
lastname
mc-lastname
This does result in a shorter URL than if we included all of them, but could present issues where a double-word first name could be split incorrectly (think "Mary Jane Doe" where firstname should be Mary Jane and lastname should be Doe).
One alternative is to combine like this:
firstname
ormc-firstname
combines tomc-firstname
lastname
ormc-lastname
combines tomc-lastname
Name
splits intomc-firstname
andmc-lastname
A second option is combining like this:
firstname
ormc-firstname
combines tomc-firstname
lastname
ormc-lastname
combines tomc-lastname
mc-firstname
andmc-lastname
are needed, combine toName
Name
is used, combinemc-firstname
andmc-lastname
into it.Are there any other ideas for how to construct the link? I prefer the first option. The link will be a touch longer (there's a limit, but I'm not sure where that limit is), but will generate better names (as in the "Mary Jane" case)
Other
I think that covers everywhere that this is an issue. Have I missed anything?