gOOvER / GuildGreet-Extended

A Greeting Addon for WoW
Other
4 stars 3 forks source link

Frame is off screen #22

Closed lownignitus closed 6 years ago

lownignitus commented 7 years ago

Some how I have ended up placing the GG frame anchor outside of the edge of the screen. I now cannot figure out how to, easily, get it to show back up on my screen.

It there something I can do, or a debug setting that can be toggled to revert its position back to default?

celina commented 7 years ago

I installed GG for the first time from Twitch (formally Curse) and my frame is off the screen and looks totally wonky. Please see my screenshot- it has not been cropped and was taken in full screen. This add-on is unusable in this state. screen shot 2017-05-15 at 6 16 52 pm

gOOvER commented 7 years ago

Whats your Screen Size??? I can't confitm that..

But i will not fix this in this Version. I work an a Rewrite for that window, but it takes time :)

celina commented 7 years ago

My computer's native resolution is 1366 x 768. I use many addons and I've never seen one that doesn't natively fit or scale to fit my screen but this one.

I've attached additional screenshots to show how other interfaces appear. Are the options for this addon so big that they can't fit on my screen like everything else?

screen shot 2017-05-22 at 8 25 00 pm screen shot 2017-05-22 at 8 24 09 pm screen shot 2017-05-22 at 8 19 47 pm

lownignitus commented 7 years ago

My question is, do the GG frame have a utilize clamptedToScreen?

lownignitus commented 7 years ago

Yeah I would suggest adding clampToScreen="true" to your xml of the frame creation would solve my issue, you are missing this.

gOOvER commented 7 years ago

I will test this and if it work, i will add it :) ty

gOOvER commented 7 years ago

https://github.com/gOOvER/GuildGreet-Extended/commit/f618089a79944bdffccba4da697844ca71a82f5c

gOOvER commented 7 years ago

As is said; i'm really unhappy with then Configuration Frame and i want to rewrite this.

lownignitus commented 7 years ago

Well that fixed his configuration screen maybe, but not my notification frame issue.

List frame<-->
<Frame name="GuildGreetList" toplevel="true" parent="UIParent" hidden="true" enableMouse="true" movable="true">

should have look like:

List frame<-->
<Frame name="GuildGreetList" toplevel="true" parent="UIParent" hidden="true" enableMouse="true" movable="true" clampToScreen="true">

this way the frame does not dispensary off the screen like the issue I was having. I switched from 5760x1080 resolution back to 1920x1080. I had the List frame on a side monitor, not center of my triple monitors, and the List Frame was hidden off my screen. Adding the clampedToScreen will prevent this from happening, or people accidentally moving it off screen.

lownignitus commented 7 years ago

This is a good habit to get into on any frame that you make movable. Prevents issue as I am encountering. I have implemented this on all my addons.

gOOvER commented 7 years ago

i will fix that tonight... Thank you :)

gOOvER commented 7 years ago

Sorry for delay:

https://github.com/gOOvER/GuildGreet-Extended/commit/aba62c6f2d65b561c2b32cc602edfc8e5b270a62

lownignitus commented 7 years ago

Awesome. This solves my issue for sure. And am glad to help you make a positive addition to the addon.

reaper666735 commented 7 years ago

are you sure it's fixed ? , still having the same issue with latest 7.3 build, and my resolution is 1920 x 1080 wowscrnshot_092217_135659

lownignitus commented 7 years ago

Same build, same stated resolution. Some how I think your in game resolution is not truly 1920x1080, just guessing. image

reaper666735 commented 7 years ago

well i don't know what to tell you ...... , i aint lying :p

wowscrnshot_092517_170214

lownignitus commented 7 years ago

That is really odd then, cause yeah you should have no issues. I would have to update stuff on the wifes pc to be able to view it on a none modded game anymore.

reaper666735 commented 6 years ago

@gOOvER what do you think of this ?

Edrard commented 6 years ago

I have same issue there - https://i.imgur.com/uZfXUI7.png My resolution is 1920x1200, I tryed window mode but its not helped Interface scale setted to 1

reaper666735 commented 6 years ago

seems this issue needs to be re-opened :p , can anyone do that ?

gOOvER commented 6 years ago

i do not have Problems with that and can't really reproduce for testing.

i will take a look, when i have more time

reaper666735 commented 6 years ago

and ofc still having the massive screen issue to this date :)

reaper666735 commented 6 years ago

as i just mentioned on the 8.0.1 issue ticket, this is still happening for me :'(

gOOvER commented 6 years ago

As i wrote can't reproduce it. I ask a lot of Users and noone have this issue. I will see what i can do, when i have the time for it

reaper666735 commented 6 years ago

yeah i know it's weird, if i can give more information somehow that could help just let me know ok :)