search

gQSPSim / gQSPSim_public

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Update gQSPsim with contributions from MathWorks #2

Closed simkaryote closed 1 year ago

simkaryote commented 1 year ago

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY.

simkaryote commented 1 year ago

See

https://stackoverflow.com/questions/3796927/how-do-i-git-clone-a-repo-including-its-submodules

Pax

From: feigelman @.> Sent: Friday, December 9, 2022 8:31:52 PM To: gQSPSim/gQSPSim_public @.> Cc: Rick Paxson @.>; Author @.> Subject: Re: [gQSPSim/gQSPSim_public] Update gQSPsim with contributions from MathWorks (PR #2)

running the new version of the code locally after merging I immediately encounter problems with the advanced logger. That directory app/+QSPViewerNew/+Widgets/AdvLogger is empty. I assume that is supposed to track https://github.com/mathworks/advanced-loggerhttps://github.com/mathworks/advanced-logger as a submodule. However, even after cloning that in I encounter the following error. Do you have a modified local version of this module? It's not in the repository that I can tell. Otherwise I don't know why it's looking for undefined properties in the Logger class.

No public property 'FileID' for class 'Logger'.

Error in QSPViewerNew.Widgets.Logger/fcloseLogFile (line 198) if obj.FileID >= 0

Error in QSPViewerNew.Widgets.Logger/moveLogFile (line 93) obj.fcloseLogFile();

Error in QSP.Session/updateLoggerName (line 847) moveLogFile(loggerObj, obj.RootDirectory); % moves log file if not present in root dir

Error in QSP.Session/setSessionName (line 544) updateLoggerName(obj, SessionName)

Error in QSPViewer.App/refreshhttp://QSPViewer.App/refresh (line 81) setSessionName(obj.Session(idx),ThisRawName);

Error in uix.abstract.AppWithSessionFiles/createUntitledSession (line 223) obj.refresh(); %Call refresh of the main app

Error in uix.abstract.AppWithSessionFiles/onNew (line 153) createUntitledSession(obj);

Error in uix.abstract.AppWithSessionFiles>@(h,e)onNew(obj) (line 66) 'Callback',@(h,e)onNew(obj));

Error while evaluating Menu Callback.

With this error, I cannot launch the app

— Reply to this email directly, view it on GitHubhttps://github.com/gQSPSim/gQSPSim_public/pull/2#issuecomment-1344966707, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEW6B5IWNC3F2RLGX5BPZNDWMPMQRANCNFSM6AAAAAASDZWKCI. You are receiving this because you authored the thread.Message ID: @.***>

simkaryote commented 1 year ago

I am gong to force the pull request into dev. It's been too long waiting for the approval and code changes from outside MathWorks are leaking into this pull request. I don't think it is controversial anymore that this new refactor will be part of v2.