gWorldz / get-simple-cms

Automatically exported from code.google.com/p/get-simple-cms
GNU General Public License v3.0
0 stars 0 forks source link

URLs of first-level subpages of index do not work #225

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It appears that index's first-level subpages are getting a faulty URL, in the 
form of "www.example.com/index/subpage-slug" as opposed to 
"www.example.com/subpage-slug". This also causes the links to 404. The problem 
was discussed in the forums and a patch against /admin/inc/basic.php was posted 
to remove the /index/ part. Link to the forum post below.

http://get-simple.info/forum/post/15214/#p15214

Original issue reported on code.google.com by leo.nikk...@gmail.com on 3 Jul 2011 at 8:56

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r511.

Original comment by ccagle8 on 3 Jul 2011 at 12:15

GoogleCodeExporter commented 9 years ago
i love these types of issues where the fix is right in the comments. Thanks!

Original comment by ccagle8 on 3 Jul 2011 at 12:17

GoogleCodeExporter commented 9 years ago
I posted that fix, but didn't open an issue here because I've always thought it 
was meant to be that way...

leo: what are those "links to 404"?

Original comment by carnav on 3 Jul 2011 at 8:04

GoogleCodeExporter commented 9 years ago
When I clicked on the links of the subpages in the navigation the pages were 
not found, it returned a 404 error and that patch fixed it as well. Thanks for 
coming up with that fix!

Original comment by leo.nikk...@gmail.com on 3 Jul 2011 at 9:05

GoogleCodeExporter commented 9 years ago
strange, I don't get any 404 error, links with "/index/" work ok for me.
Did you change anything in your .htacess file?

Original comment by carnav on 3 Jul 2011 at 9:25

GoogleCodeExporter commented 9 years ago
Sorry, I remembered incorrectly, links such as example.com/index/subpage direct 
to the index page instead of the subpage without that patch, they don't give a 
404. Apart from the RewriteBase rule I haven't changed anything, compared it 
with a vanilla .htaccess file. Attached is my .htaccess. GetSimple root is at 
localhost/getsimple/

Original comment by leo.nikk...@gmail.com on 3 Jul 2011 at 11:05

Attachments:

GoogleCodeExporter commented 9 years ago
the more i think about this, i am afraid of effecting older installations that 
might be using the /index/ subfolder in their URLs. I am going to revert this 
back since its really not causing a problem...

Original comment by ccagle8 on 4 Jul 2011 at 12:11

GoogleCodeExporter commented 9 years ago
leo: my .htaccess is identical, but localhost/getsimple/index/subpage displays 
the same as localhost/getsimple/subpage , as expected.
Could it be that you tried localhost/getsimple/subpage/index instead? (that 
would display the same as localhost/getsimple/ or localhost/getsimple/index)

Chris: I agree it's better leaving it like it was. Anyway it's so easy to patch 
if you need it the other way... (like they did with get-simple.de)

Original comment by carnav on 4 Jul 2011 at 1:24

GoogleCodeExporter commented 9 years ago
No, I'm sure it was index/subpage, maybe it's my installation. I'll try with a 
fresh one later today to see if it's just my config or some plugins.

Original comment by leo.nikk...@gmail.com on 4 Jul 2011 at 1:57