gWorldz / get-simple-cms

Automatically exported from code.google.com/p/get-simple-cms
GNU General Public License v3.0
0 stars 0 forks source link

theme editor missing wrapper #333

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Why was the theme page wrapper removed ?

I think it was r707.

This breaks the appearance and layout of the page, all backend pages have a 
white background wrapper. Removig it was not the proper fix for whatever this 
issue was.

Now the whole page is gray and out of line with the backend style.

Original issue reported on code.google.com by tablatronics on 29 Jun 2012 at 4:53

GoogleCodeExporter commented 9 years ago
I've just installed a fresh 3.1.2 and this looks fine to me, color wise. 

There was a problem with the gutter text being having a different line-height 
to the main body which i've just fixed. 

Original comment by MichaelS...@gmail.com on 29 Jun 2012 at 5:33

GoogleCodeExporter commented 9 years ago
Can we move #themecontent out of codemirror.css ?
It should be in template styles.

And maybe we should look into refactoring codemirror so we can update it more 
easily.
Stick all the modes into their own js file.
Also make the css not customized and use a wrapper for codemirror, since it 
inherits most of its styles.

Original comment by tablatronics on 29 Jun 2012 at 8:06

GoogleCodeExporter commented 9 years ago
Ill fix this up and check it in.

Original comment by tablatronics on 29 Jun 2012 at 8:48

GoogleCodeExporter commented 9 years ago
Fixed
r736

#themecontent kludge 
was breaking page when nohighlight is on, moved it to style.php

ideally we want to get rid of those pre rules on maincontent, global styles 
liek that are bad. I am not sure what uses it, but we can in the meantime put 
maincontent back and use something more specific to override like.

#maincontent .main .codemirror pre {}

Original comment by tablatronics on 30 Jun 2012 at 2:10

GoogleCodeExporter commented 9 years ago

Original comment by tablatronics on 7 Jul 2012 at 6:37