gWorldz / get-simple-cms

Automatically exported from code.google.com/p/get-simple-cms
GNU General Public License v3.0
0 stars 0 forks source link

Unable to check GetSimple version on installation. #54

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
To be fair, the summary of this problem isn’t the core of the problem.
Lately when I installed the latest SVN version of GetSimple on my local
server it hasn’t been able to check for updates on installation.

The real problem is this: if you want to check the latest version through
the GetSimple API you have to send along the API key. If you don’t it
returns blank. Apparently the installation had put my API key to nothing.

Searching through the code why this happened brought me to the
generate_salt() function. My server has cURL enabled and will therefore use
this function to generate my API key. This function returned NULL.

My guess is, the current API key generation page takes a long time to load
(why?) and cURL will time-out before it has received any data. No second
check is been done to see whether generate_salt() actually outputs
anything. The script assumes that, because you have cURL, it will give you
a key.

Should we put a salt generator with the GetSimple to fix this?
Or maybe it would be better to not require an API key when requesting the
latest Getsimple version?

Let me know what you think.

Original issue reported on code.google.com by martijn.personal@gmail.com on 29 May 2010 at 12:34

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
fixed in 2.03

Original comment by ccagle8 on 13 Oct 2010 at 4:07