search

gXLg / libr-getter

Allows you to bruteforce a librarian villager for the desired enchantment
MIT License
14 stars 1 forks source link

Update to Minecraft 1.20.2 #18

Closed 7coil closed 8 months ago

7coil commented 9 months ago

This is a configuration update to Minecraft Normal Edition 1.20.2 - It does not work with 1.19.3, which means this PR isn't ready to go in immediately.

This may need a new version to accommodate.

gXLg commented 9 months ago

Does it even make sense to update to 1.20.2? What I mean is - the new villager update fixes the brute forcing. Also, with predefined enchantments from librarians, I would not think, that the 1.20.2 port is just adjusting the version number, I believe the Villager class may have been modified and needs adjustment in the code as well.

7coil commented 9 months ago

The new villager update is not on 1.20.2 (thankfully)

7coil commented 9 months ago

With the changes in the PR, I also have managed to fill up my villager trading hall with the mod.

The only problem I have is getting it to work with multiple previous Minecraft versions, hence the change in version number.

gXLg commented 8 months ago

Alright, I will look into it then

7coil commented 8 months ago

For completeness sake, and for anyone else interested - The new villager trade updates are under the "Villager Trade Rebalance" experimental toggle. https://minecraft.wiki/w/Java_Edition_1.20.2#Experimental_changes

7coil commented 8 months ago

Also works with 1.20.3 if you change the fabric.mod.json file :)

gXLg commented 8 months ago

It seems, 1.20.2 and Warden are compatible, so I am closing this PR now