search

gXLg / libr-getter

Allows you to bruteforce a librarian villager for the desired enchantment
MIT License
14 stars 1 forks source link

Further Enhancements #23

Open gXLg opened 7 months ago

gXLg commented 7 months ago

Users are welcome to add their ideas below

MilesTFox commented 6 months ago
gXLg commented 6 months ago

I was successfully able to merge CherryBlossom and Warden releases locally, going to work on merging further versions

Edit: merged 1.20.4 through out to 1.17.1

gXLg commented 6 months ago

  • offhanding the lecterns, so you can place/break without switching slots.

    • non-librarian villagers/workstations, with ID matching. So like, look for the cheapest carrots on a farmer.

    • non-minecraft:NAME enchantments like enchantmentsolution:soulbound, etc.

    • non 'minecraft:enchanted_book' enchantments. enchantmentsolution ones are on minecraft:book

@MilesTFox

Are you able to add those non-minecraft:NAME enchantments through /librget add <enchantment>?

MilesTFox commented 5 months ago

I was not able to.

On Sat, Feb 24, 2024 at 8:47 PM gXLg @.***> wrote:

-

offhanding the lecterns, so you can place/break without switching slots.

  non-librarian villagers/workstations, with ID matching. So like,
  look for the cheapest carrots on a farmer.
  -

  non-minecraft:NAME enchantments like enchantmentsolution:soulbound,
  etc.
  -

  non 'minecraft:enchanted_book' enchantments. enchantmentsolution
  ones are on minecraft:book

Are you able to add those non-minecraft:NAME enchantments through /librget add ?

— Reply to this email directly, view it on GitHub https://github.com/gXLg/libr-getter/issues/23#issuecomment-1962783606, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCDFEXYPP2TFDBF5DJWX4TYVKJ3RAVCNFSM6AAAAABCDJAVCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSG44DGNRQGY . You are receiving this because you commented.Message ID: @.***>

gXLg commented 5 months ago

That's bad, I will have to figure out, how to get all registered enchantments. But hey, that's what "learning" is for

MilesTFox commented 5 months ago

Might have to be a config file or allowing setting anything, because the additional enchantments are server-side via a plugin, and there is no client-side mod.

On Mon, Feb 26, 2024 at 5:07 PM gXLg @.***> wrote:

That's bad, I will have to figure out, how to get all registered enchantments

— Reply to this email directly, view it on GitHub https://github.com/gXLg/libr-getter/issues/23#issuecomment-1965385100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCDFEXNHZ4GGZQWOBKDKT3YVUBTXAVCNFSM6AAAAABCDJAVCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGM4DKMJQGA . You are receiving this because you were mentioned.Message ID: @.***>

gXLg commented 5 months ago

Ah, that makes sense! Currently my mod parses only the data saved on the client. My data structure however would theoretically allow to enter "setting anything" as an option, so I will work on it and release in the next update! Thanks!

gXLg commented 5 months ago

@MilesTFox image This was actually quite doable. The update will soon come out!

gXLg commented 5 months ago

@MilesTFox added in v2.0.1

SamAurel commented 3 months ago

Could you recolor the remove button in the list (to cyan or something) and maybe add such a button to the success message (Successfully found whatever 2 after 45 tries for a price of 21 emeralds (remove))

gXLg commented 3 months ago

@SamAurel adding color for the "remove" button is a great idea. As for the remove button in the end result - there is /librget config removegoal for that

SamAurel commented 3 months ago

Thanks for the fast response, I used that for a bit, but stopped because I wanted more control over the goals list. Its not a pressing issue as I can just remove the goal with a quick command, just an idea I had. :)

gXLg commented 3 months ago

Alright, I think I might add it anyways