Things you'd like specific feedback on:
-One of the last things I did was add a winning text to the end of the game dynamically. Before it was 3 lines of HTML, maybe 1 in CSS, and 2 in JS. Now it's no HTML and 13 lines of JS, is this bad. The reason I changed it was because I was getting a huge space at the top of my page when the div was hidden, causing a lot of page scrolling, which felt like bad UX.
-I couldn't figure out how to remove the data-color attribute, and make my code not rely on colors. How can I go about this? Like what if I wanted to add cat pictures instead of colors, I feel like I'm stuck with colors in my code.
Link to repo: https://github.com/SuperJones/project1/tree/master Link to deployed app: http://superjones.github.io/project1/
Things you'd like specific feedback on: -One of the last things I did was add a winning text to the end of the game dynamically. Before it was 3 lines of HTML, maybe 1 in CSS, and 2 in JS. Now it's no HTML and 13 lines of JS, is this bad. The reason I changed it was because I was getting a huge space at the top of my page when the div was hidden, causing a lot of page scrolling, which felt like bad UX. -I couldn't figure out how to remove the data-color attribute, and make my code not rely on colors. How can I go about this? Like what if I wanted to add cat pictures instead of colors, I feel like I'm stuck with colors in my code.