search

ga-wdi-boston / aws-s3-setup-guide

Other
3 stars 108 forks source link

016/iam update #20

Open BenGitsCode opened 7 years ago

BenGitsCode commented 7 years ago

This branch repairs erroneous changes made by @bengitscode in #13 merged from 016/master.

Most importantly, the .gitignore never should have been updated and doing so removed the only content it should have, credentials.csv and .env, while adding in the full node-template .gitignore.

Additionally, the IAM section had redundant steps and downright incorrect information due to my misunderstanding of the process. Those errors have been fixed, and the language further clarified.

S3 section was accurate but I added some more clarifying language there as well.

Any non-critical issues are open as issues, these are critical.

jrhorn424 commented 7 years ago

Would it be appropriate to ignore all .csv files? Would it be appropriate to block both credentials.csv and accessKeys.csv? @gaand