search

ga-wdi-boston / ember-object

Explore the Ember Object Model, and leverage it to do some basic binding through computed properties.
Other
1 stars 112 forks source link

Remove route demo #11

Open RealWeeks opened 8 years ago

RealWeeks commented 8 years ago

Seems unnecessary.

RealWeeks commented 8 years ago

removed in commit 14f5e3a

gaand commented 8 years ago

Please explain why this was in this lesson and why you removed it. Thanks!

RealWeeks commented 8 years ago

@gaand No idea why it was in the lesson, so I removed it. Seemed out of scope.

RealWeeks commented 8 years ago

On second thought, I think it's better removed. This is covered very in depth in routing-static

gaand commented 8 years ago

Okay. I just want to make sure that before you remove something form a lesson, you've thought about why it might be there. For instance, does covering it briefly here support covering it in more depth later? I don't know, but it might be worth thinking through.

jrhorn424 commented 8 years ago

I agree with @gaand. Please take a bit longer to explain your thoughts in PRs and issues. It helps me since I'm not in the room and not always a part of the conversations you have.