Remove all naked access, assignment, and execution

[jrhorn424]

The principle driving this issue is called "The Principle of Uniform Access".

It helps that adhering to this principal will avoid bugs, and that breaking this principle in Ember will break your application code in odd and hard-to-debug ways.

// GIVEN
const Person = Ember.Object.extend({
  givenName: null,
  familyName: null,
});

const Developer = Person.extend({
  jobTitle: 'Developer',
  doJob () {
    return 'Computering';
  },
});

let jeff = Developer.create({
  givenName: 'Jeffrey',
  familyName: 'Horn',
});

// BAD
jeff.givenName; // some Ember junk
// GOOD
jeff.get('givenName'); // "Jeffrey"

// BAD
jeff.givenName = 'J-Rizzle' // let's break Ember
// GOOD
jeff.set('givenName', 'J-Rizzle'); // "J-Rizzle"

// BAD
jeff.doJob(); // 'Computering'
// GOOD
jeff.get('doJob')(); // 'Computering'

As a specific example for execution done wrong in this talk:

const Person = Ember.Object.extend({
  fullName: function(){
    return `${this.get('givenName')} ${this.get('surname')}`;
  }
});

let bob = Person.create({
  givenName: 'Bob',
  surname: 'Belcher'
})

-bob.fullName(); // 'Bob Belcher'
+bob.get('fullName')(); // 'Bob Belcher'

[gaand]

Is this solved more cleanly with a computed property? Is it too soon to talk about that with this talk?

[raq929]

@jrhorn424 The current example is beetlejuicing, we should definitely remove it.

[MicFin]

This example in particular

const Person = Ember.Object.extend({
  fullName: function(){
    return `${this.get('givenName')} ${this.get('surname')}`;
  }
});

let bob = Person.create({
  givenName: 'Bob',
  surname: 'Belcher'
})

bob.get('fullName')(); // 'Bob Belcher'