search

ga-wdi-boston / ember-template

Other
5 stars 43 forks source link

016/default #22

Closed payne-chris-r closed 7 years ago

payne-chris-r commented 7 years ago

Not sure if the auth service should be in there as blank, but I thought it'd give us a place to start...

raq929 commented 7 years ago

There's a failing test on this PR having to do with the application serializer. The serializer doesn't actually DO anything, so I'm not sure how much it matters? But I think it should pass or be deleted.

The test passes on master.

raq929 commented 7 years ago

I didn't mean to close, just comment.

raq929 commented 7 years ago

Also, I think we should probably deal with these warnings, although I guess that's updating node globally.

DEPRECATION: Node v5.10.1 is no longer supported by Ember CLI. We recommend that you use the most-recent "Active LTS" version of Node.js.
WARNING: Node v5.10.1 is not tested against Ember CLI on your platform. We recommend that you use the most-recent "Active LTS" version of Node.js.
payne-chris-r commented 7 years ago

Is this the one you're talking to?

Promise rejected before "it serializes records": Attempting to register an unknown factory: 'model:application'

?

raq929 commented 7 years ago

That's the one.

raq929 commented 7 years ago

There's no application model. So I think we can safely delete the application serializer and this test. Because I lied. On master, this test doesn't exist.

payne-chris-r commented 7 years ago

It's possible that I didn't create the application serializer correctly. I'm gonna take a look.

payne-chris-r commented 7 years ago

I feel like application shouldn't have a model, but maybe it's showing that there's an issue with how active-model-serializer is being brought in?

raq929 commented 7 years ago

Right, the serializer expects a model. Otherwise what would it serialize? So I think we can kill it?

payne-chris-r commented 7 years ago

Sounds like we're trying to extend an adapter that doesn't exist... I'm punting on this because it sounds like an issue with the version of ember-data we're using, not with the current update (see my soon-to-be-pushed branch). As you'll see my vote on this is to leave #23 open and continue doing what I was trying to do (de-podify), and come back to this later (if necessary) with 23.