search

ga-wdi-boston / ember-template

Other
5 stars 43 forks source link

Remove container-fluid from body in index.html #8

Open payne-chris-r opened 8 years ago

payne-chris-r commented 8 years ago

<body class="container-fluid"> should be something the user adds IMO. Maybe we leave it there to show you can add classes to the body in index.html? Not sure. It just drove me insane for 15 minutes though.

gaand commented 8 years ago

Ember does some bootstrapy stuff when you install bootstrap-sass, so that should probably be investigated?

raq929 commented 7 years ago

I would actually support removing this from browser-template as well. (pending investigation)

gaand commented 7 years ago

@raq929 This means I won't merge your pull. Perhaps this is the correct change, but I do not believe this has been investigated or discussed enough to warrant the action you took.

raq929 commented 7 years ago

Sorry, I meant to test it and then remove the commit before making the pull. I'll update and re-push the branch.

jrhorn424 commented 7 years ago

I don't care if it goes. I added it originally because developers forget to add it themselves and then their apps bleed all the way to the viewport edge and it drives me nuts.

It just drove me insane for 15 minutes though.

That's not a good reason to remove something, IMO. You should know better. 😛

payne-chris-r commented 7 years ago

^ 100%. I was just frustrated and it didn't make sense to me that it would be there.