search

ga-wdi-boston / ember

Introduction to Ember.js
Other
9 stars 112 forks source link

Check if we talk about pods vs. classic? #16

Open payne-chris-r opened 7 years ago

payne-chris-r commented 7 years ago

@jrhorn424 and I were talking about the difference between pods and classic and that codeschool does it classic, we do pods, and to talk briefly about the differences. This may be covered in a later lesson or in the template, but should at least be somewhere.

raq929 commented 7 years ago

I did talk about this in the lesson, because the diagram uses the other file structure.

So basically, show:

├── application/
│   │   ├── adapter.js
│   │   ├── serializer.js
│   │   └── template.hbs
├── rentals/
│   │   ├── model.js
│   │   ├── route.js
│   │   └── template.hbs

vs.

├── adapters/
│   │   ├── application.js
│  
├── models/
│   │   ├── rentals.js
│  
├── routes/
│   │   ├── rentals.js
│  
├── templates/
│   │   ├── application.js
│   │   ├── rentals.js
│  
├── serializers/
│   │   ├── application.js
│  
payne-chris-r commented 7 years ago

I think this no longer needs to be covered if/when we change to classic/default instead of pod structure.

MicFin commented 7 years ago

Can this be closed per #27?

jrhorn424 commented 7 years ago

A brief grep of #27 reveals no addition or removal of "pod" or "classic" or "structure". If this was a question and was adequately addressed, can @payne-chris-r or @rts please confirm? Alternatively, @MicFin can provide a reason for closing not related to #27, or if I'm wrong, tell me how.

I think that covers all the scenarios?

MicFin commented 7 years ago

I potentially misunderstood the changes. The folder structure matched the changes that @raq929 suggested above which also matched the ember-template so I thought it could be closed. This should remain open for further review.

payne-chris-r commented 7 years ago

We don't talk about pods vs. default, and when I opened this issue I didn't really understand the difference either. I would argue that we don't need as much as an emphasis (or to talk about it at all) now that we've transitioned to the default approach. Ember barely talks about it. Unless Ember 3 uses pods over default I vote for ignoring it in these talks (even though I personally like it more than default).