ga-wdi-boston / game-project

Other
7 stars 102 forks source link

GitHub Pages - Deployment Missing JS Files #303

Closed coffeeisamazing closed 8 years ago

coffeeisamazing commented 8 years ago

Linter Output

~/wdi/projects/game-project (gh-pages)$ grunt nag
Running "jshint:all" (jshint) task
>> 6 files lint free.

Running "jsonlint:all" (jsonlint) task
>> 6 files lint free.

Running "jscs:status" (jscs) task
>> 6 files without code style errors.

Done.

Execution Time (2016-11-01 14:24:48 UTC-4)
loading tasks  763ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 68%
jshint:all     110ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇ 10%
jscs:status    245ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 22%
Total 1.1s

Issue Description

[ what you were doing when the problem showed up ] App working as expected locally. Receiving errors on gh pages. https://coffeeisamazing.github.io/game-project/

[ error message (as text), if one exists ] From console on gh pages.

2016-11-01 14:23:23.589 coffeeisamazing.github.io/:7 GET https://coffeeisamazing.github.io/game-project/vendor.bundle.js 
2016-11-01 14:23:23.594 coffeeisamazing.github.io/:8 GET https://coffeeisamazing.github.io/game-project/bundle.js 

[ the code that caused the error (as a fenced code block) or ] Here is my git ignore file.

tmp
dist
specs.js
_SpecRunner.html
*.woff2
*.woff
*.svg
*.ttf
*.eot

# Created by https://www.gitignore.io/api/node,osx,linux,windows,ruby,node,rails,express,ember

### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

### OSX ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon

# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk

### Linux ###
*~

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

### Windows ###
# Windows image file caches
Thumbs.db
ehthumbs.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msm
*.msp

# Windows shortcuts
*.lnk

### Ruby ###
*.gem
*.rbc
/.config
/coverage/
/InstalledFiles
/pkg/
/spec/reports/
/spec/examples.txt
/test/tmp/
/test/version_tmp/
/tmp/

# Used by dotenv library to load environment variables.
# .env

## Specific to RubyMotion:
.dat*
.repl_history
build/
*.bridgesupport
build-iPhoneOS/
build-iPhoneSimulator/

## Specific to RubyMotion (use of CocoaPods):
#
# We recommend against adding the Pods directory to your .gitignore. However
# you should judge for yourself, the pros and cons are mentioned at:
# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
#
# vendor/Pods/

## Documentation cache and generated files:
/.yardoc/
/_yardoc/
/doc/
/rdoc/

## Environment normalization:
/.bundle/
/vendor/bundle
/lib/bundler/man/

# for a library or gem, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
# Gemfile.lock
# .ruby-version
# .ruby-gemset

# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
.rvmrc

### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

### Rails ###
*.rbc
capybara-*.html
.rspec
/log
/tmp
/db/*.sqlite3
/db/*.sqlite3-journal
/public/system
/coverage/
/spec/tmp
**.orig
rerun.txt
pickle-email-*.html

# TODO Comment out this rule if you are OK with secrets being uploaded to the repo
config/initializers/secret_token.rb

# Only include if you have production secrets in this file, which is no longer a Rails default
# config/secrets.yml

# dotenv
# TODO Comment out this rule if environment variables can be committed
.env

## Environment normalization:
/.bundle
/vendor/bundle

# these should all be checked in to normalize the environment:
# Gemfile.lock, .ruby-version, .ruby-gemset

# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
.rvmrc

# if using bower-rails ignore default bower_components path bower.json files
/vendor/assets/bower_components
*.bowerrc
bower.json

# Ignore pow environment settings
.powenv

# Ignore Byebug command history file.
.byebug_history

#!! ERROR: express is undefined. Use list command to see defined gitignore types !!#

### Ember ###
# see https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/gitignore
# compiled output
/dist
/tmp

# dependencies
/node_modules
/bower_components

# misc
/.sass-cache
/connect.lock
/coverage/*
/libpeerconnection.log
npm-debug.log
testem.log

[ the code that isn't working as expected ] https://coffeeisamazing.github.io/game-project/

[ things you've tried to fix the problem ] Tried both commenting out the appropriate lines as well as deleting all-together.

[ the last point at which code worked ] Never worked on github pages.

raq929 commented 8 years ago

I took a look at this. vendor.bundle.js and bundle.js are definitely there on the gh-pages branch, but the get requests generated by the HTML are failing.

jrhorn424 commented 8 years ago

Sometimes it takes a while for the github CDN to update. If it isn't a path issue, I don't know what it could be. Please check the index and make sure there aren't any other links that might be trying to double-load the bundles or include source files directly instead of relying on the two bundles.

coffeeisamazing commented 8 years ago

Still no luck. I tried wiping out the local and remote gh-pages branch and starting from scratch - same result.

I don't see any double-loading occurring.

coffeeisamazing commented 8 years ago

Fixed it! I had previously (prior receiving the deployment instructions) setup gh pages based on my master for just a simple html page to test the deployment process. The target branch was still using master. I updated master to gh-pages under settings and did a fresh push to the gh pages branch and it worked.

BenGitsCode commented 8 years ago

Is this still an issue @coffeeisamazing? If so I can take a look today.

coffeeisamazing commented 8 years ago

Working fine now, thanks @BenGitsCode. I put the solution up above. Lesson learned: Double check what branch your github pages are pointing to under Settings... :)