search

ga-wdi-boston / git-github

Lesson to introduce Github, forking, cloning and synchronizing change between team members.
Other
0 stars 83 forks source link

Descope the upstream stuff #10

Open jrhorn424 opened 8 years ago

jrhorn424 commented 8 years ago

As a percentage of delivery time, the current upstream stuff is way too big.

I got great feedback about this. I think upstream needs to be mentioned. Focus on the git add remote command. That should be the only thing in the lab (maybe also git fetch --all) at this point in the program. Future units should talk about updating from upstream. This should make the lab much shorter.

RealWeeks commented 7 years ago

@jrhorn424 Can you add a bit more insight? Just add upstream. Is it even worth it then? Should I just completely remove the upstream stuff?

@gaand You have an issue open on this as well, what were you hoping to see and how can both issue be accomplished?

https://github.com/ga-wdi-boston/git-github/issues/5

payne-chris-r commented 7 years ago

I think this unraveled our lesson a bit when we got in to upstream, just FYI. I'll try to grab @J-Weeks and give him the 30 second run down of what happened.

jrhorn424 commented 7 years ago

@payne-chris-r It'd be great to know what went wrong. I'll check #3

payne-chris-r commented 7 years ago

I think it just added a layer of complexity that confused things. I think it's ok to talk about, just do CFUs for origin first. Then ass upstream.

MicFin commented 7 years ago

See related issues about upstream being included in the talk.

  1. git remote add upstream could be confused with push --set-upstream in Remotes section https://github.com/ga-wdi-boston/git-github/issues/12
  2. PVD Delivery https://github.com/ga-wdi-boston/git-github/issues/11
  3. Include adding upstream? https://github.com/ga-wdi-boston/git-github/issues/5