search

ga-wdi-boston / git

Other
0 stars 107 forks source link

Explain why one should not use `git commit -m "<one line message>"` #11

Closed gaand closed 8 years ago

gaand commented 8 years ago

Explain ramifications from an employment perspective.

Model good commit messages, headline, blank line, detail.

Not even on first commit:

Initial commit

Starting from `ga-wdi-boston/js-template`.
jrhorn424 commented 8 years ago

related to #4

jrhorn424 commented 8 years ago

This appears to be fixed as of 5c75e031acf0b99eb606437364eacc5327365da9. @gaand please confirm.

gaand commented 8 years ago

I don't see it in the diff. Is there a different commit?

jrhorn424 commented 8 years ago

Several. "as of" was meant to imply the commits weren't cohesive enough. Apologies for that. Let me find a diff.

gaand commented 8 years ago

Ah. Sorry. I'm doing this from my iPhone.

jrhorn424 commented 8 years ago

@gaand https://github.com/ga-wdi-boston/git-basics/compare/1a3f9ff3d47c8c682bc1421f113939d4539772fc...5c75e031acf0b99eb606437364eacc5327365da9

jrhorn424 commented 8 years ago

Oops! Sorry, this wasn't actually addressed yet. Wrong issue.

jrhorn424 commented 8 years ago

The title was addressed, but not the body.

RealWeeks commented 8 years ago

@jrhorn424 addressed in commit 23bd767. Thoughts?

gaand commented 8 years ago

I think this is done. I'll close. please reopen if I missed something outstanding for this issue.