search

ga-wdi-boston / html-css-layout-bootstrap-sass

Other
1 stars 163 forks source link

Remove modals #28

Open raq929 opened 7 years ago

raq929 commented 7 years ago

@jrhorn424 and I are in violent agreement that we should not teach modals because they cause way more problems than they are worth. Refactor to remove use of modals.

raq929 commented 7 years ago

Developers are generating modals via handlebars, which leads to a bunch of problems with having duplicate IDs, and about 7 people in 016 had the issue of doing a delete or update, and making an API call to the server to refresh their list. If they didn't close the modal before updating the list (which removes the modal they had open), the screen remains grey and locked (due to boostrap modal behavior).

MicFin commented 7 years ago

Some of the functionality like the Modal Events and Triggering a Modal in a callback definitely trips people up because they have to combine some concepts. The issue with multiple of the same ID's I think is more a result of how (poorly) the Handlebars lesson was received.

The Handlebars lesson landed on a half day after a snow day and we lost our time to do the lab. I wonder if the problem isn't that modals themselves are too hard (although they certainly add a layer of complexity and sometimes oddities like modals inside modals), but potentially they didn't fully understand the objectives from the Handlebars lesson that we needed them to in order to be successful at using the modals.

A lot of people dislike modals purely from a UX perspective, which is fine but also opinionated. I like modals for the same reason many new developers do, they are interactive and neat. Bootstrap modals are pretty flexible so I think they might be getting a slightly worse reputation than they deserve, but I'm not opposed to seeing them removed from the lesson. I would just suspect that even if we remove them, developers will still end up using them (unless we outright ban them, at which point I think we would have gone too far).

raq929 commented 7 years ago

015 had the same issues (or worse) without the snowday problem. I agree with your second point though. So maybe teach them, but include checking out the documentation explicitly, and also include another strategy? hmmm... then we run into talk too long issues.

Jcornmanhomonoff commented 7 years ago

Spoke with @raq929, @jrhorn424, and @gaand. Holding off on removing modals and including explicit discussion about not using jQuery show/hide.