search

ga-wdi-boston / html-css-layout-bootstrap-sass

Other
1 stars 163 forks source link

Developers don't seem to use bootstrap generated events with modals #9

Open gaand opened 8 years ago

gaand commented 8 years ago

Which I believe led to many of their problems using them.

jrhorn424 commented 8 years ago

Like modalClosed etc?

gaand commented 8 years ago

Yeah. It may actually be more complicated than my issue indicates. I need to research it a bit.

MicFin commented 7 years ago

Any additions to this issue for cohort 016? Planning to present without closing the issue.

gaand commented 7 years ago

@ga-wdi-boston/core Please ping me when preparing this talk next time so we can discuss this (unless it's made obsolete buy other curriculum changes).

jrhorn424 commented 7 years ago

Is it appropriate to address this during the Modals lab?

jrhorn424 commented 7 years ago

Related #28

jrhorn424 commented 7 years ago

This has come up a few times. Most recently, folks are using setTimeout to indeterminately avoid a race condition with handlebars-rendered modals.

@raq929 recalls this happening many times in 015 as well (though no one used setTimeout to avoid it).

My preferred solution is to use the modal instance methods bootstrap provides on modal elements via its jQuery plugins. http://getbootstrap.com/javascript/#modals-methods

raq929 commented 7 years ago

I'd prefer to get rid of using modals altogether and teach bootstrap generated events a different way.

jrhorn424 commented 7 years ago

I'd prefer to get rid of using modals altogether and teach bootstrap generated events a different way.

Me too! #28

Jcornmanhomonoff commented 7 years ago

Including explicit discussion about not using jQuery show/hide & using Bootstrap methods instead.