What code smells should we add?

ga-wdi-boston / html-css

High-level overview of HTML and CSS.

Other

4 stars 170 forks source link

What code smells should we add? #11

Closed jrhorn424 closed 7 years ago

jrhorn424 commented 8 years ago

Early CSS examples for the game project show that some developers are using numbers in their class names, and copying styles between them.

I don't think any changes need to be made, other than an emphasis on DRY in CSS, but @MattB-GA-Boston may have more information.

laurenfazah commented 8 years ago

I created a new attributes table to draw emphasis on class, id, and data-*. Really hoping to drill down what's used where, when and why to avoid these smells.

jrhorn424 commented 8 years ago

@ga-wdi-boston/core Should we include a list of code smells and best practices in this lesson?

jrhorn424 commented 7 years ago

Closed in favor of #2