search

ga-wdi-boston / jquery-dom-diagnostic

Other
0 stars 168 forks source link

jquery diag #143

Closed akadane87 closed 7 years ago

raq929 commented 7 years ago

It looks like you're struggling with the syntax for jQuery, and need to review. I strongly recommend doing the tutorial that we used in the study, and continuing on past the first level that we did in the study; it covers most of what we learned in class. Let me know if you want to talk more about it!

raq929 commented 7 years ago

1/8

akadane87 commented 7 years ago

For sure! Thanks for the critiques as always

On Sun, Oct 30, 2016 at 9:05 PM, Rachel S. notifications@github.com wrote:

@raq929 commented on this pull request.

In diagnostic.md https://github.com/ga-wdi-boston/jquery-dom-diagnostic/pull/143:

@@ -23,7 +23,7 @@ Write the jQuery code to navigate from one of the list item (li) DOM nodes to the form DOM node. (Assume the list item has a class of "listerItem").

+$('.listerItem').parents('form');

Ha! I had never run into parents() before, good find! In that case, I would probably do $('li').parents('body').children('form'). Which is awesome, as it's shorter than the other way. The way you did it wouldn't work because form is a sibling of the ol, so it's never a parent of the li. Thanks for showing me that, though!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ga-wdi-boston/jquery-dom-diagnostic/pull/143, or mute the thread https://github.com/notifications/unsubscribe-auth/AMIYCBy4g3Fd7Or3o3Alko7WUpMz1Ahdks5q5T7kgaJpZM4KiWUQ .