search

ga-wdi-boston / jquery-dom

Other
0 stars 139 forks source link

Added some sample html to index for example/lab. #16

Closed payne-chris-r closed 8 years ago

payne-chris-r commented 8 years ago

@berziiii just added some sample html to make the lab go smoothly. Take a look for me?

gaand commented 8 years ago

@payne-chris-r Please lowercase tag names.

payne-chris-r commented 8 years ago

Updated @gaand. Great catch.

gaand commented 8 years ago

I missed this in my last review, but this isn't based on the index.html from the current template. I'll open an issue if necessary.

payne-chris-r commented 8 years ago

Yeah, this PR isn't necessary. I was going to use an HTML page to build a DOM diagram in addition to the wireframe example because I think it makes a lot of sense visually. I didn't end up using it, and it isn't necessary, but might be a nice tool in the event someone wants to do just that.

gaand commented 8 years ago

If obsolete, please close the pull request. If not, perhaps open an issue and also close the pull request.

payne-chris-r commented 8 years ago

Closing because it IS obsolete.

jrhorn424 commented 8 years ago

I was going to use an HTML page to build a DOM diagram in addition to the wireframe example because I think it makes a lot of sense visually.

I like that. Can you explain more? Did you have a tool that would analyze the source and produce a tree? (other than the browser, of course... 😄)