search

ga-wdi-boston / js

Other
36 stars 212 forks source link

const initialization required in all environments #51

Open gaand opened 7 years ago

gaand commented 7 years ago

Contra: https://github.com/ga-wdi-boston/js#constants

raq929 commented 7 years ago

Did this change recently? I could have sworn we tried this in the browser in 015 and got undefined.

gaand commented 7 years ago

@raq929 Did you try it? In what version of node/chrome?

raq929 commented 7 years ago

I tried it in chrome, and it works the way you say it will; throws an error. Maybe it was in node that I did it with in class; I just tried it on this computer (older version of node) and got undefined. (I wasn't arguing that the change shouldn't be made, I was just curious about when it happened. Which appears to be somewhere btwn node 5.10 and the current version we're using (which I didn't check).

On Sun, Mar 26, 2017 at 2:31 PM Antony Donovan notifications@github.com wrote:

@raq929 https://github.com/raq929 Did you try it? In what version of node/chrome?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ga-wdi-boston/js/issues/51#issuecomment-289303300, or mute the thread https://github.com/notifications/unsubscribe-auth/ANRw2I4f_qhkrIMOi97S9nR8kQDStaKmks5rpqqHgaJpZM4MjATk .

gaand commented 7 years ago

I believe it occurred with the update of V8 included in node v6