search

ga-wdi-boston / mongodb-crud

An introduction to MongoDB
Other
1 stars 136 forks source link

Prefer javascript operator keys over string this references. #10

Open gaand opened 8 years ago

gaand commented 8 years ago

Mention both?

Focus on the latter.

Avoid strings being interpreted as JavaScript.

RealWeeks commented 7 years ago

^ Do not use strings, period. Via @gaand

RealWeeks commented 7 years ago

@gaand removed all refs in commit efaa08b. There was only one ref, all code refs were removed in earlier commits, okay to close?

neugierige commented 7 years ago

@gaand @payne-chris-r ok to close?

MicFin commented 7 years ago

Emphasis from @gaand during planning to not mention string references for cohort 016

gaand commented 7 years ago

@MicFin A note about that in the README.md might be appropriate.

MicFin commented 7 years ago

This was addressed specifically in the delivery for 016 and the README was adjusted to fit the format. However, after delivery, I found that some strings were still being used and will need to be removed for next delivery so this should not be closed.

Please review the master and solution branches.

Example of strings still being used in master https://github.com/ga-wdi-boston/mongodb-crud#demo-update-books

Example of strings still being used in solution https://github.com/ga-wdi-boston/mongodb-crud/blob/solution/scripts/update/books.js