search

ga-wdi-boston / mongodb-crud

An introduction to MongoDB
Other
1 stars 136 forks source link

Solution Branch needs attention #16

Open payne-chris-r opened 8 years ago

payne-chris-r commented 8 years ago

There's an issue (#14 ) that references one problem. It also could just use some other fill-out for examples. This is one of those repos that a lot of the discussion happens using the command line interacting with Mongo, but filling out some of those scripts for the discussion would be great. We should also attend to #15 when we do this if possible.

RealWeeks commented 8 years ago

I added a few more scripts in for the code-along portion. But like you said alot of this is intertwined with discussion so I usually ask when they want to query then build it with them using the docs.

berziiii commented 7 years ago

Solution is now 1 commit ahead of master. see commit 173eb50009ba0f2efc4a03f1ed6302e4cda4ef83

gaand commented 7 years ago

@MicFin The solution is 2 ahead, 2 behind.

MicFin commented 7 years ago

I see. https://github.com/ga-wdi-boston/mongodb-crud/commit/6f89dd55958b36c5081cd5469fea298998697f4f

Note for future cohort:
The mistakes that were made (package.json name being corrected) during PR review were done as commits on both master and solution. This could/should have been avoided by delivering the talk and opening an issue for the corrections to be made before next delivery.

jrhorn424 commented 7 years ago

It also could have been avoided by rebasing <cohort>/solution against <cohort>/master.

NEVER do the same work on two branches in two different commits.