search

ga-wdi-boston / rails-api-bdd

Other
4 stars 131 forks source link

ga-wdi-boston/rails-api-bdd #1

Open jrhorn424 opened 8 years ago

payne-chris-r commented 8 years ago

This lecture is built to go all day, and just get as far as you can. We did, and it was awesome.

laurenfazah commented 8 years ago

Combining -bdd and -bdd-iteration went really well in my opinion. Developers didn't seem to be overwhelmed and we landed at 3:30 for the final lab (testing the comments resource). They're going to go as far as they can with that.

payne-chris-r commented 8 years ago

I did this lesson similarly to how I had before (because I'm not sure I quite understand the way it has been refactored). We did Feature -> Unit tests for all CRUD on Articles, then did the Model test which includes relationships. I told them to do what we did in class with Articles for Comments in the Lab/homework/extra practice. Having done this and now trying to understand how it's been refactored, I think the new method has validity, but the tests don't drive the development in the same way. If we give them the code for the Controllers, we're really just teaching them to write tests that the pre-existing code in the controller satisfy. I thought the intent of this lesson was to write tests before we write code, write code, refactor til the tests pass, etc. Are we just giving them the Controller code to save time?

payne-chris-r commented 8 years ago

It took me a long time. I had fun with it, but I let it take too long. Full afternoon and following morning, plus a unit after lunch. 1-4, 9:40 -> 12, 1-2 = ~6.5 units

danman01 commented 7 years ago

Spent 5 units (one full day, ending at 4pm) on this, and we did not get to the model associations or comments. So, could easily be 6-7. While I thought we may have been going too slow for more advanced devs, this talk was even tripping up some of the people who always get things quickly, so it was good to take time, go over things multiple times, multiple code-alongs. I felt the division of code-along to lab was pretty good.

There's so much that could go into a chunk of talks on testing. I think moving testing models and associated resources (comments) into it's own 2 unit talk would be good. For another talk, not like there's any time for it, but using mocks, fixtures / factories, automating with Guard, BDD with something like cucumber, browser tests with capybara, continuous deployment, might all be nice topics.

danman01 commented 7 years ago

Got through CRUD actions, ample time given for labs and explanation. Split between two days, so the 2nd day we spent a little time reviewing. When we got to the model and association section, I simply talked through it, and spent more time going back over the learning objectives instead of rushing into the model / association specs. Great to have the additional resources in the readme so developers can continue their learning.