ga-wdi-boston / rails-api-bdd

Other
4 stars 131 forks source link

Does not support HTTPS #2

Closed edesilets closed 8 years ago

edesilets commented 8 years ago

/gem.rb

gem 'rails-api', git: 'git@github.com:rails-api/rails-api.git'
gem 'active_model_serializers', git: 'git@github.com:rails-api/active_model_serializers.git'

Updated for support for HTTPS /gem.rb

gem 'rails-api', git: 'https://github.com/rails-api/rails-api.git'
gem 'active_model_serializers', git: 'https://github.com/rails-api/active_model_serializers.git'

Support for both would be great.

jrhorn424 commented 8 years ago

I don't believe this is valid. @gaand care to comment?

gaand commented 8 years ago

@jrhorn424: @erdesi90562 uses two factor auth. I'd guess he doesn't have an ssh key loaded and so can't use the ssh url. Github only allows unauthenticated requests (to public repos) via https.

jrhorn424 commented 8 years ago

@erdesi90562 You need to setup SSH access and use SSH urls when you clone.