ga-wdi-boston / ruby-object-class-methods

Other
0 stars 130 forks source link

Why were these requirements excluded from the Album/Song example? #23

Closed jrhorn424 closed 7 years ago

jrhorn424 commented 7 years ago

I'd like to discuss the reason I had them in there in the first place.

jrhorn424 commented 7 years ago

I see. I think the requirements were lost because they weren't included in the list for Lab, or they were included in a funny/unclear way:

Use this class method to set YOUR favorite Album by searching for the album title.

jrhorn424 commented 7 years ago

Possibly reopen #15?

raq929 commented 7 years ago

Oh! No, they weren't included because we're not using class instance variables any more (per @gaand), so the albums array has to be immutable. I'd love to chat about this more.

gaand commented 7 years ago

Since ruby has become threaded, access to anything not an instance variable or immutable should be guarded by mutexes. Since delving into this area is well beyond the scope of WDI, I believe it's probably best to exclude it.

jrhorn424 commented 7 years ago

Thanks @gaand!