jingrid commented 7 years ago

Hello

We're trying to create the controller for our nested schema, but we're having trouble referencing the right things.

Essentially, we have a schema/model for Blog, and we are trying to make Posts nested within Blog.

cpearce31 commented 7 years ago

Can you post what you have so far? Are you getting errors?

jingrid commented 7 years ago

We took the Blog controller and just changed it to make it work for Posts

'use strict'

const controller = require('lib/wiring/controller')
const models = require('app/models')
const Blog = models.blog

const authenticate = require('./concerns/authenticate')
const setUser = require('./concerns/set-current-user')
const setModel = require('./concerns/set-mongoose-model')

const index = (req, res, next) => {
  Blog.post.find()
    .then(posts => res.json({
      posts: posts.map((e) =>
        e.toJSON({ virtuals: true, user: req.user }))
    }))
    .catch(next)
}

const show = (req, res) => {
  res.json({
    blog: req.blog.toJSON({ virtuals: true, user: req.user })
  })
}

const create = (req, res, next) => {
  const post = Object.assign(req.body.blog.post, {
    _owner: req.blog._id
  })
  Blog.post.create(post)
    .then(post =>
      res.status(201)
        .json({
          post: post.toJSON({ virtuals: true, blog: req.blog })
        }))
    .catch(next)
}

const update = (req, res, next) => {
  delete req.body._owner  // disallow owner reassignment.
  req.blog.update(req.body.blog)
    .then(() => res.sendStatus(204))
    .catch(next)
}

const destroy = (req, res, next) => {
  req.blog.remove()
    .then(() => res.sendStatus(204))
    .catch(next)
}

module.exports = controller({
  index,
  show,
  create,
  update,
  destroy
}, { before: [
  { method: setUser, only: ['index', 'show'] },
  { method: authenticate, except: ['index', 'show'] },
  { method: setModel(Blog), only: ['show'] },
  { method: setModel(Blog, { forUser: true }), only: ['update', 'destroy'] }
] })

However, when we try to create a Post, we are getting a 500 error: "{"error":{"message":"Cannot read property 'post' of undefined","error":{}}}"

Our curl request is as follows:

!/bin/bash

API="http://localhost:4741" URL_PATH="/blogs"

curl "${API}${URL_PATH}/${ID}/posts" \ --include \ --request POST \ --header "Content-Type: application/json" \ --header "Authorization: Token token=${TOKEN}" \ --data '{ "post": { "title": "'"${TITLE}"'", "body": "'"${BODY}"'" } }'

echo

Our custom route is: .post('/blogs/:id/posts', 'posts#create')

cpearce31 commented 7 years ago

Cannot read property 'post' of undefined suggests that you have some code like thing.post, where thing is undefined. You should be able to confirm that's what's happening with some console.logs.

payne-chris-r commented 7 years ago

Refactored your code a lil bit by adding "``js" and "bash" around your curl script.

payne-chris-r commented 7 years ago

We took the Blog controller and just changed it to make it work for Posts

'use strict'

const controller = require('lib/wiring/controller')
const models = require('app/models')
const Blog = models.blog

const authenticate = require('./concerns/authenticate')
const setUser = require('./concerns/set-current-user')
const setModel = require('./concerns/set-mongoose-model')

const index = (req, res, next) => {
  Blog.post.find()
    .then(posts => res.json({
      posts: posts.map((e) =>
        e.toJSON({ virtuals: true, user: req.user }))
    }))
    .catch(next)
}

const show = (req, res) => {
  res.json({
    blog: req.blog.toJSON({ virtuals: true, user: req.user })
  })
}

const create = (req, res, next) => {
  const post = Object.assign(req.body.blog.post, {
    _owner: req.blog._id
  })
  Blog.post.create(post)
    .then(post =>
      res.status(201)
        .json({
          post: post.toJSON({ virtuals: true, blog: req.blog })
        }))
    .catch(next)
}

const update = (req, res, next) => {
  delete req.body._owner  // disallow owner reassignment.
  req.blog.update(req.body.blog)
    .then(() => res.sendStatus(204))
    .catch(next)
}

const destroy = (req, res, next) => {
  req.blog.remove()
    .then(() => res.sendStatus(204))
    .catch(next)
}

module.exports = controller({
  index,
  show,
  create,
  update,
  destroy
}, { before: [
  { method: setUser, only: ['index', 'show'] },
  { method: authenticate, except: ['index', 'show'] },
  { method: setModel(Blog), only: ['show'] },
  { method: setModel(Blog, { forUser: true }), only: ['update', 'destroy'] }
] })

However, when we try to create a Post, we are getting a 500 error: "{"error":{"message":"Cannot read property 'post' of undefined","error":{}}}"

Our curl request is as follows:

#!/bin/bash

API="http://localhost:4741"
URL_PATH="/blogs"

curl "${API}${URL_PATH}/${ID}/posts" \
  --include \
  --request POST \
  --header "Content-Type: application/json" \
  --header "Authorization: Token token=${TOKEN}" \
  --data '{
    "post": {
      "title": "'"${TITLE}"'",
      "body": "'"${BODY}"'"
    }
  }'

echo

Our custom route is:

.post('/blogs/:id/posts', 'posts#create')

payne-chris-r commented 7 years ago

See @cpearce31 's suggestion.

jordanallain commented 7 years ago

perhaps this line?

Blog.post.create(post)

can you see what Blog is at that point in your create action?