search

ga-wdi-boston / upload-client

Other
3 stars 122 forks source link

Discuss naming for this sequence #16

Open gaand opened 7 years ago

gaand commented 7 years ago

Is this to long?

payne-chris-r commented 7 years ago

I think it is too long. I think browser-upload is fine. Express-multer is a backend concern. Technically the only job of this repo is the upload.

payne-chris-r commented 7 years ago

Thoughts @gaand @jrhorn424 ? photo-uploader?

payne-chris-r commented 7 years ago

client-uploader?

jrhorn424 commented 7 years ago

@payne-chris-r and I discussed and felt it was important enough to take a stab at new naming.

We decided to go with upload-client for now.

I'm not sure it's an adequate name, especially if we break out the command line script into its own talk, because technically the CLI is also a client.

gaand commented 7 years ago

I don't think the talk should be based on browser-template. More importantly, breaking it into distinct pieces would help more.

I think this sequence needs to be multiple talks, e,g handling uploads on the server, sending to s3 from wherever, sending files to a server from the client - these are not necessarily in order.

payne-chris-r commented 7 years ago

Taking some of our conversation out of slack and into here... From @gaand: Have at least three repositories. One for S3 (node-template), one for multer (express-api-template), one for the client (browser-template). I don't know about using upload in place of multer since there are more ways to handle uploads in express. And I'd like to chat about disconnecting talks from template based repositories.

payne-chris-r commented 7 years ago

The idea as of now is: browser-upload is based on talk-template and outlines the whole process, referencing the other two (maybe future 3) repos. upload-client is based on browser-template and just houses the client forms for the process express-api-upload is based on express-api-template and houses the api and is where we do most of the work. Moving forward we may want an s3-upload that is based on node-template that is just a node script that does the s3 upload (the beginning piece of this talk)

payne-chris-r commented 7 years ago

BONUS: add a rails-api-upload that features paperclip and shows an example of using rails to upload files to AWS