016/master - Githubissues

ga-wdi-boston / upload-client

Other

3 stars 122 forks source link

016/master #20

Closed payne-chris-r closed 7 years ago

jrhorn424 commented 7 years ago

Can you confirm whether this should be merged since the conversation we had with @gaand? I believe he objected to both the naming and structure we had discussed but I'm not sure about the details. Basically trying to figure out:

Should this be merged or just closed?
Should I be opening an issue to record my thoughts here, or in instructors?

payne-chris-r commented 7 years ago

It should be merged. It's not exactly what @gaand and I talked about after I gave this talk, but it's closer than its current state. The name upload-client is fine. He has feelings about not having the name multer in the api repo because that's what its purpose is "to mult things." I'm not 100% convinced yet, but I understand where he's coming from and I don't have a strong enough opinion to fight over it.