search

ga-wdi-exercises / pixart_js

Use JS events and programmatically generated DOM elements to build a drawing application. [javascript, dom]
MIT License
9 stars 321 forks source link

Pz solution #116

Closed pzhang87 closed 8 years ago

pzhang87 commented 8 years ago

comfort: 4 completeness: 4.5

I thought this was going to be much harder than I thought, but it turns it wasn't bad at all.

A few things I want to think about: the bonus objective, figuring out how to implement click-drag functionality instead of just mouseover, possible refactoring, and deleting miscellaneous commented-out code.

Something I'm not sure on (hence the 4.5) - the enter key seems to duplicate a click event inside the input field; was there something else that we were supposed to do here, like preventDefault and creating our own event handler for pressing the enter key?

nolds9 commented 8 years ago

:+1: Great job! See inline comments, and let me know if you have any other questions.