search

ga-wdi-exercises / pixart_js

Use JS events and programmatically generated DOM elements to build a drawing application. [javascript, dom]
MIT License
9 stars 321 forks source link

Caitlin solution #156

Closed caitlindaitch closed 8 years ago

caitlindaitch commented 8 years ago

Comfort level: 4 Completeness: 5

Finished except for the bonus!

beckybeauchamp1 commented 8 years ago

Hi Caitlin,

Good morning, hope you are having a nice weekend! Good job on Pixart, especially completing this exercise during project week! I left additional comments inline for further advise and feedback on individual components of your code. I wanted to highlight a few additional pieces of feedback as well:

  1. Some of your commits are in past tense, but we should really be writing all commits in present tense. For example, on your 4th commit instead of "Created 20 divs" It should be "Creates 20 divs". I know this is picky, but its good to start getting in the habit!
  2. Continue thinking about how you could further move the global variables into either a separate function or maybe just a separate object. Also, it's good practice especially in these exercises to look for any duplication in your code and try to further refactor it. Specifically, look at my comments and your code for enterColorInput and setColorButton functions.

Great job, let me know if you have any more questions :+1: