Colleen OReilly solution

ga-wdi-exercises / pixart_js

Use JS events and programmatically generated DOM elements to build a drawing application. [javascript, dom]

MIT License

9 stars 321 forks source link

Closed colleeno closed 7 years ago

colleeno commented 7 years ago

completion - 5 confidence - 5

everything plus bonus are working, noticed some unexpected things.

couldn't store the input color value immediately in global scope? had to declare without value, then re-assign. something to do with having to submit first I'm guessing?
couldn't set up a variable for the divs at the top. I had to move it to below the function that creates them. I would have assumed it could have been set at the top?

jsm13 commented 7 years ago

👍 Great job!

I might be misunderstanding, but I think you're describing setting the color based on the input when you declare the variable. This is because initially the input is empty and it's not until the user enters a color that we are able to grab that value.
The reason the divs couldn't be created at the top is that $('.square') is going to target element in the document so before they are appended, the won't be found.

If I missed the question on either of those let me know.