Comfort: 4
Completeness: 4 (no bonus or commit #2)
I liked this assignment. jQuery definitely helps make things easier, although admittedly I didn't use it as much as I could have (particularly when pulling the color from the input field). I also played around with different formats when constructing the event listener for the color boxes, and found myself mixing syntax between jQuery and JS with expected errors resulting. That's why I put a 4 for comfort as opposed to a 5.
Two notes: the CSS change in Commit 6 was already completed in the original master, so that should be changed for future versions. Also, Google Chrome already captures hitting the enter key within forms as equivalent to a click, obviating the need for that piece of additional code. If I were to add it in, I'd probably use an if statement tied to an event.key="Enter" condition.
jshawl
commented
9 years ago
Comfort: 4 Completeness: 4 (no bonus or commit #2)
I liked this assignment. jQuery definitely helps make things easier, although admittedly I didn't use it as much as I could have (particularly when pulling the color from the input field). I also played around with different formats when constructing the event listener for the color boxes, and found myself mixing syntax between jQuery and JS with expected errors resulting. That's why I put a 4 for comfort as opposed to a 5.
Two notes: the CSS change in Commit 6 was already completed in the original master, so that should be changed for future versions. Also, Google Chrome already captures hitting the enter key within forms as equivalent to a click, obviating the need for that piece of additional code. If I were to add it in, I'd probably use an if statement tied to an event.key="Enter" condition.