search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

add more query parameters to the GET #108

Closed redmitry closed 2 years ago

redmitry commented 2 years ago

"start", "end", "assemblyId", "referenceName", "referenceBases" and "alternateBases" as defined in https://github.com/ga4gh-beacon/beacon-v2-Models/blob/main/BEACON-V2-Model/genomicVariations/requestParameters.json

related to https://github.com/ga4gh-beacon/beacon-v2-Models/pull/107

mbaudis commented 2 years ago

... see also the discussion here https://github.com/ga4gh-beacon/beacon-v2-Models/issues/50 @Tom-Shorter

mbaudis commented 2 years ago

@jrambla Regarding the missing genomicAlleleShortForm parameter: There is identifiers.genomicHGVSId in the default model. Added in https://github.com/ga4gh-beacon/beacon-v2-Models/pull/109

mbaudis commented 2 years ago

@redmitry @jrambla Seems good to me now.

redmitry commented 2 years ago

Lets flow params from RequestProperty and GET both directions :-) +1

Tom-Shorter commented 2 years ago

+1 for defining the GET parameters, I did make comments about the start/end being type:array but after thinking about it for a second longer it does seem the correct approach so I removed them

mbaudis commented 2 years ago

@redmitry @Tom-Shorter thanks for the notes - merging.