search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

Correcting errors in all endpoints.json #21

Closed jrambla closed 3 years ago

jrambla commented 3 years ago

I have spotted one repeated error in the endpoints.json files in every entry type folder. My regular OpenAPI editor did not catch it, but Swagger Editor did. It refers to the {id} parameter in the path and the POST operations. It clears out one doubt we had about potential conflicts. It also simplifies the requestParameters definitions for most entry types.

I've corrected all affected definitions.

jrambla commented 3 years ago

@Tom-Shorter are you familiar enough with OpenAPI to check if my deduction and correction are right?

Tom-Shorter commented 3 years ago

@Tom-Shorter are you familiar enough with OpenAPI to check if my deduction and correction are right?

Sorry @jordi, I don't have the experience or knowledge to double check the changes made in terms of openAPI correctness.