search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

GET "/g_variants" : "includeResultsetResponses" parameter goes nowhere. #29

Closed redmitry closed 2 years ago

redmitry commented 3 years ago

Hello,

In the genomicVariations/endpoints.json :

"paths": {
  "/g_variants": {
    "get": {
      "parameters": [
          { "$ref": "#/components/parameters/includeResultsetResponses" },

"components": {
  "parameters": {
    "includeResultsetResponses": {
      "$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-framework-v2/main/requests/beaconRequestBody.json#/definitions/IncludeResultsetResponses"

beacon-framework-v2/requests/beaconRequestBody.json has no /difinitions.

IMO this is a "copy/paste" error and "$ref" should be: "https://raw.githubusercontent.com/ga4gh-beacon/beacon-framework-v2/main/common/beaconCommonComponents.json#IncludeResultsetResponses"

Cheers,

Dmitry