search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

frequencyInPopulations as child of variantLevelData #47

Closed mbaudis closed 2 years ago

mbaudis commented 3 years ago

As discussed in #46 , frequencyInPopulations should be part of the variantLevelData.

Tom-Shorter commented 3 years ago

I'm going to leave this for @mbaudis and @jrambla to discuss. Once a decision has been made I'll either approve/decline based on the outcome of the convo (or remove me as a reviewer).

jrambla commented 2 years ago

Sorry, I believe that this is a major change and I rather prefer to get the feedback of the adopters before doing such change,

mbaudis commented 2 years ago

Ok; as indicated, the current version works although the nesting isn't totally logical.