search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

replacing position -> VRS.Location #71

Closed mbaudis closed 2 years ago

mbaudis commented 2 years ago

Following the discussions with @ahwagner today, here is a first proposal replacing the private genomicVariations.Definitions.Position for position with location -> "$ref": "https://raw.githubusercontent.com/ga4gh/vrs/1.2.0/schema/vrs.json#/definitions/Location"

mbaudis commented 2 years ago

Pinging @mrueda @ahwagner ...

tb143 commented 2 years ago

This change will require work/time from our side to implement. We don't predict any major issues.

mbaudis commented 2 years ago

Closing this in favour of https://github.com/ga4gh-beacon/beacon-v2-Models/pull/72.

ahwagner commented 2 years ago

I'm confused; this is #71. What was this closed in favor of?

mbaudis commented 2 years ago

C&P error; apologies. There is agreement that the more extensive alignment in #72 should work well; so I closed this one...