search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

"Quantity" json schema error. #74

Closed redmitry closed 2 years ago

redmitry commented 2 years ago

Hello,

quantity.json schema has an error: the incoherence in the property name:

"properties": {
    "units": {
      "$ref": "./commonDefinitions.json#/definitions/Units"
    },
"required": ["unit", "value"],

must be: "required": ["units", "value"]

Cheers,

D.

mbaudis commented 2 years ago

@redmitry This has been addressed in https://github.com/ga4gh-beacon/beacon-v2-Models/pull/67 - plural is wrong for all instances... Please have a look & comment there.

redmitry commented 2 years ago

Ah! Sorry, false alarm.