search

ga4gh-beacon / beacon-v2-Models

Models that leverage the Beacon Framework v2
Apache License 2.0
4 stars 7 forks source link

Broken cross-repo references #75

Closed gsfk closed 2 years ago

gsfk commented 2 years ago

Hello!

The Models and Frameworks repo mix url and relative path references in a way that leads to dead ends, at least for me. For example, the variants endpoints spec includes this reference to the spec for responses from a boolean beacon:

https://github.com/ga4gh-beacon/beacon-v2-Models/blob/08cb436eed0534e380487652279cb29597cd9d16/BEACON-V2-draft4-Model/genomicVariations/endpoints.json#L213

But the spec retrieved from that link contains relative path references to code inside the Frameworks repo:

"$ref": "./sections/beaconResponseMeta.json"

so the reference can't be resolved. This is only one example, there are several more with the same issue.

mbaudis commented 2 years ago

This is a general issue - can be fixed, but the logical thing would be to move to a unified repository https://github.com/ga4gh-beacon/beacon-v2-Models/issues/76#