search

ga4gh-beacon / beacon-v2

Unified repository for the GA4GH Beacon v2 API standard
Creative Commons Zero v1.0 Universal
27 stars 22 forks source link

Framework refactor entry type definitions #102

Closed mbaudis closed 1 month ago

mbaudis commented 1 year ago

Some streamlining of the entryTypesDefinition schema. I think this is just a streamlining of the code which was a bit confusing but please check ...

mbaudis commented 1 year ago

... also this seems to update the develop branch w/ a massive code alignment.

@costero-e => Please decide about the branch management there and think about cleaning/retiring branches which aren't used anymore ¯_(ツ)_/¯

costero-e commented 1 year ago

For the branches management, this is the short-term plan: Deleted branches genomicVariations_add-pathogenicity-predictions clean-up_remove-validator-remnants clean-up_remove_aggregated_response

Branches that will be deleted after PR #92 entry-type-definitions-cleanup

Branches that will be deleted after PR #90 hotfix_filteringTermsResults

Branches that will be deleted after PR #82 schema-urgent-fixes

Branches that will be deleted after PR #74 clean-up_renaming_entity_to_entry_type

Branches that will be deleted after this PR (#102) framework-refactor-entry-type-definitions

For the mid-term plan, I will write what we are doing in every branch and add milestones and achievements.

jrambla commented 10 months ago

Is this PR still mergeable?

costero-e commented 10 months ago

Hi @jrambla . Yes, it is mostly documentation and style updates apart from http to https changes. I think this won't break specifications. We need 1 pending review.

costero-e commented 1 month ago

Closing this PR as some of this was already merged in other PR and conflicting files did not make it mergeable anymore.