search

ga4gh-beacon / beacon-v2

Unified repository for the GA4GH Beacon v2 API standard
Creative Commons Zero v1.0 Universal
27 stars 22 forks source link

add scopes[] to the FilteringTerm #109

Closed redmitry closed 10 months ago

redmitry commented 1 year ago

The patch is the response to the several discussions #93, #94.

beaconFilteringTermsResults.json FilteringTerm should provide a list of scopes (entryTypes) the filter may be applied,

Dmitry

costero-e commented 1 year ago

Everything looks fine except for the example, as we have discussed in person, the json should look like this:

                    "examples": [
                        ["individual", "biosample"]
                    ],

The yaml looks good but without the commas.

jrambla commented 10 months ago

It looks good to me. Not to be corrected in this PR, but the example "Human Phenotype Ontology" is wrong as it is not part of the type enum.