search

ga4gh-beacon / beacon-v2

Unified repository for the GA4GH Beacon v2 API standard
Creative Commons Zero v1.0 Universal
27 stars 22 forks source link

invalid CURIE example #111

Closed redmitry closed 5 months ago

redmitry commented 1 year ago

Hello,

In the HandoverType example beaconCommonComponents.json#HandoverType one of the "id" has a value "CUSTOM" which is not a qualified CURIE. Current CURIE pattern : beaconCommonComponents.json#CURIE defines CURIE being qualified :

Definition of an identifier in the CURIE 'prefix:local-part`'format.

Many implementations just put the word "CUSTOM" from the example that makes responses invalid.

Cheers,

D.

costero-e commented 1 year ago

Hi Dmitry,

yes, this was addressed recently in issue #83, so maybe there are still some implementations that have not updated this.

Best,

Oriol

mbaudis commented 5 months ago

Closing this since the schema had been fixed; erroneous implementations can be pointed to the respective issue & PR.