ga4gh-beacon / beacon-v2

Unified repository for the GA4GH Beacon v2 API standard
Creative Commons Zero v1.0 Universal
24 stars 20 forks source link

Request parameter `g_variant.end` should have a minimum of 1 value #130

Open mbaudis opened 2 months ago

mbaudis commented 2 months ago

The current definition of end says that it should have a minimum of 0 items. This is wrong and conflates the optional nature of the parameter with its content[^1].

https://github.com/ga4gh-beacon/beacon-v2/blob/afaf76ac3e4ce6c48fa5da571b7883046ccef020/models/src/beacon-v2-default-model/genomicVariations/requestParameters.yaml#L51

This needs to be fixed; if end is being used it has to have be a list of 1 or 2 integers.

[^1]: This originates from an earlier use in Beacon v1 where queries were always for positional elements and.

mbaudis commented 2 months ago

@costero-e I have committed the fixes to thew schema-urgent-fixes branch

Please clean up :-)

costero-e commented 2 months ago

This is being requested to merge here #82, can you review @jrambla ?