search

ga4gh-beacon / beacon-v2

Unified repository for the GA4GH Beacon v2 API standard
Creative Commons Zero v1.0 Universal
23 stars 20 forks source link

Updating "definitions" (deprecated) to "$defs" in some Json schemas #153

Open jrambla opened 1 month ago

jrambla commented 1 month ago

Some Json files include the "defnitions" element. In Json schema '2020-12' it has been deprecated to "$defs". VS Code validator, at least, is complaining about that.

@mbaudis should I edit the json version directly or should the source generator from YAML? (I haven't spotted the place on it)

mbaudis commented 1 month ago

@jrambla I'll do. The "some" adds up since it's not only the definitions: but also the references to them e.g. #/definitions/ResultsetInstance ... I'll change & make a PR for review.

Re editing: Yes, YAML version and then local use of `bin/vamlerRunner.sh' which I wrote for locally performed schema conversion. It uses a function to keep the json parameters in order; when editing by hand this might lead to changed files which git wants to update then (purely due to changed order).